Maven GAE plugin config updates (#2442)

* Maven config updates

* lint

* lint

* lint

Author: averikitsch

cloud-sql/mysql/servlet/README.md

@@ -62,7 +62,7 @@ environment variables into the runtime.
 
 Next, the following command will deploy the application to your Google Cloud project:
 ```bash
-mvn appengine:deploy
+mvn clean package appengine:deploy
 ```
 
 ### Deploy to Cloud Run

cloud-sql/mysql/servlet/pom.xml

@@ -27,7 +27,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <properties>

cloud-sql/postgres/servlet/README.md

@@ -62,5 +62,5 @@ environment variables into the runtime.
 
 Next, the following command will deploy the application to your Google Cloud project:
 ```bash
-mvn appengine:deploy
+mvn clean package appengine:deploy
 ```

cloud-sql/postgres/servlet/pom.xml

@@ -27,7 +27,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <properties>

memorystore/redis/pom.xml

@@ -27,7 +27,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <properties>

storage/cloud-client/pom.xml

@@ -26,7 +26,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <properties>

storage/json-api/pom.xml

@@ -26,7 +26,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <properties>

storage/s3-sdk/pom.xml

@@ -26,7 +26,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <properties>

storage/s3-sdk/src/main/java/ListGcsBuckets.java

@@ -21,24 +21,23 @@
 import com.amazonaws.services.s3.AmazonS3;
 import com.amazonaws.services.s3.AmazonS3ClientBuilder;
 import com.amazonaws.services.s3.model.Bucket;
-
 import java.util.List;
 
 public class ListGcsBuckets {
-  public static void listGcsBuckets(String googleAccessKeyId,
-      String googleAccessKeySecret) {
+  public static void listGcsBuckets(String googleAccessKeyId, String googleAccessKeySecret) {
 
     // String googleAccessKeyId = "your-google-access-key-id";
     // String googleAccessKeySecret = "your-google-access-key-secret";
 
     // Create a BasicAWSCredentials using Cloud Storage HMAC credentials.
-    BasicAWSCredentials googleCreds = new BasicAWSCredentials(googleAccessKeyId,
-        googleAccessKeySecret);
+    BasicAWSCredentials googleCreds =
+        new BasicAWSCredentials(googleAccessKeyId, googleAccessKeySecret);
 
     // Create a new client and do the following:
     // 1. Change the endpoint URL to use the Google Cloud Storage XML API endpoint.
     // 2. Use Cloud Storage HMAC Credentials.
-    AmazonS3 interopClient = AmazonS3ClientBuilder.standard()
+    AmazonS3 interopClient =
+        AmazonS3ClientBuilder.standard()
             .withEndpointConfiguration(
                 new AwsClientBuilder.EndpointConfiguration(
                     "https://storage.googleapis.com", "auto"))
@@ -59,4 +58,3 @@ public static void listGcsBuckets(String googleAccessKeyId,
   }
   // [END storage_s3_sdk_list_buckets]
 }
-

storage/s3-sdk/src/main/java/ListGcsObjects.java

@@ -14,35 +14,32 @@
  * limitations under the License.
  */
 
-
 // [START storage_s3_sdk_list_objects]
 import com.amazonaws.auth.AWSStaticCredentialsProvider;
 import com.amazonaws.auth.BasicAWSCredentials;
 import com.amazonaws.client.builder.AwsClientBuilder;
-
 import com.amazonaws.services.s3.AmazonS3;
 import com.amazonaws.services.s3.AmazonS3ClientBuilder;
 import com.amazonaws.services.s3.model.ObjectListing;
 import com.amazonaws.services.s3.model.S3ObjectSummary;
 
-import java.util.List;
-
 public class ListGcsObjects {
-  public static void listGcsObjects(String googleAccessKeyId,
-      String googleAccessKeySecret, String bucketName) {
+  public static void listGcsObjects(
+      String googleAccessKeyId, String googleAccessKeySecret, String bucketName) {
 
     // String googleAccessKeyId = "your-google-access-key-id";
     // String googleAccessKeySecret = "your-google-access-key-secret";
     // String bucketName = "bucket-name";
 
     // Create a BasicAWSCredentials using Cloud Storage HMAC credentials.
-    BasicAWSCredentials googleCreds = new BasicAWSCredentials(googleAccessKeyId,
-        googleAccessKeySecret);
+    BasicAWSCredentials googleCreds =
+        new BasicAWSCredentials(googleAccessKeyId, googleAccessKeySecret);
 
     // Create a new client and do the following:
     // 1. Change the endpoint URL to use the Google Cloud Storage XML API endpoint.
     // 2. Use Cloud Storage HMAC Credentials.
-    AmazonS3 interopClient = AmazonS3ClientBuilder.standard()
+    AmazonS3 interopClient =
+        AmazonS3ClientBuilder.standard()
             .withEndpointConfiguration(
                 new AwsClientBuilder.EndpointConfiguration(
                     "https://storage.googleapis.com", "auto"))

storage/s3-sdk/src/test/java/ListGcsBucketsTest.java

@@ -18,7 +18,6 @@
 import static org.junit.Assert.assertThat;
 
 import com.amazonaws.services.s3.model.Bucket;
-
 import java.io.ByteArrayOutputStream;
 import java.io.PrintStream;
 import java.util.List;

storage/s3-sdk/src/test/java/ListGcsObjectsTest.java

@@ -19,7 +19,6 @@
 
 import com.amazonaws.services.s3.model.Bucket;
 import com.amazonaws.services.s3.model.ObjectListing;
-
 import java.io.ByteArrayOutputStream;
 import java.io.PrintStream;
 import java.util.List;

storage/storage-transfer/pom.xml

@@ -30,7 +30,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <properties>

storage/xml-api/cmdline-sample/pom.xml

@@ -26,7 +26,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <properties>

storage/xml-api/cmdline-sample/src/main/java/StorageSample.java

@@ -22,14 +22,12 @@
 import com.google.api.client.http.HttpResponse;
 import com.google.api.client.http.HttpTransport;
 import com.google.api.client.util.Preconditions;
-
 import java.io.IOException;
 import java.io.StringReader;
 import java.io.StringWriter;
 import java.net.URLEncoder;
 import java.security.GeneralSecurityException;
 import java.util.Collections;
-
 import javax.xml.transform.OutputKeys;
 import javax.xml.transform.Source;
 import javax.xml.transform.Transformer;

storage/xml-api/serviceaccount-appengine-sample/README.md

@@ -33,7 +33,7 @@ Running and Deploying Your Application from the Command Line
 
 To run your application locally on a development server:
 
-    mvn appengine:devserver
+    mvn appengine:run
 
 To deploy your application to appspot.com:
 

storage/xml-api/serviceaccount-appengine-sample/pom.xml

@@ -23,7 +23,7 @@
   <parent>
     <groupId>com.google.cloud.samples</groupId>
     <artifactId>shared-configuration</artifactId>
-    <version>1.0.11</version>
+    <version>1.0.12</version>
   </parent>
 
   <groupId>com.google.apis-samples</groupId>
@@ -82,14 +82,16 @@
       </plugin>
 
       <!--
-        The actual appengine-maven-plugin. Type "mvn appengine:devserver" to run project,
+        The actual appengine-maven-plugin. Type "mvn appengine:run" to run project,
         "mvn appengine:update" to upload to GAE.
       -->
       <plugin>
-        <groupId>com.google.appengine</groupId>
+        <groupId>com.google.cloud.tools</groupId>
         <artifactId>appengine-maven-plugin</artifactId>
-        <version>1.9.77</version>
+        <version>2.2.0</version>
         <configuration>
+          <projectId>GCLOUD_CONFIG</projectId>
+          <version>gaeinfo</version>
           <port>8888</port>
         </configuration>
       </plugin>

storage/xml-api/serviceaccount-appengine-sample/src/main/java/com/google/api/client/sample/storage/appengine/serviceaccount/StorageSample.java

@@ -23,12 +23,10 @@
 import com.google.api.client.http.HttpResponse;
 import com.google.api.client.http.HttpTransport;
 import com.google.api.client.http.javanet.NetHttpTransport;
-
 import java.io.BufferedWriter;
 import java.io.IOException;
 import java.io.OutputStreamWriter;
 import java.util.Arrays;
-
 import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
@@ -46,8 +44,7 @@ public class StorageSample extends HttpServlet {
   private static final int HTTP_OK = 200;
 
   /** The base endpoint for Google Cloud Storage api calls. */
-  private static final String GCS_URI =
-      "http://commondatastorage.googleapis.com";
+  private static final String GCS_URI = "http://commondatastorage.googleapis.com";
 
   /** Global configuration of Google Cloud Storage OAuth 2.0 scope. */
   private static final String STORAGE_SCOPE =
@@ -65,35 +62,30 @@ protected void doGet(final HttpServletRequest req, final HttpServletResponse res
       throws IOException {
 
     try {
-      AppIdentityCredential credential = new AppIdentityCredential(
-          Arrays.asList(STORAGE_SCOPE));
+      AppIdentityCredential credential = new AppIdentityCredential(Arrays.asList(STORAGE_SCOPE));
 
       // Set up and execute Google Cloud Storage request.
       String bucketName = req.getRequestURI();
       if (bucketName.equals("/")) {
         resp.sendError(
-            HTTP_NOT_FOUND,
-            "No bucket specified - append /bucket-name to the URL and retry.");
+            HTTP_NOT_FOUND, "No bucket specified - append /bucket-name to the URL and retry.");
         return;
       }
       // Remove any trailing slashes, if found.
-      //[START snippet]
+      // [START snippet]
       String cleanBucketName = bucketName.replaceAll("/$", "");
       String uri = GCS_URI + cleanBucketName;
-      HttpRequestFactory requestFactory =
-          HTTP_TRANSPORT.createRequestFactory(credential);
+      HttpRequestFactory requestFactory = HTTP_TRANSPORT.createRequestFactory(credential);
       GenericUrl url = new GenericUrl(uri);
       HttpRequest request = requestFactory.buildGetRequest(url);
       HttpResponse response = request.execute();
       String content = response.parseAsString();
-      //[END snippet]
+      // [END snippet]
 
       // Display the output XML.
       resp.setContentType("text/xml");
-      BufferedWriter writer = new BufferedWriter(
-          new OutputStreamWriter(resp.getOutputStream()));
-      String formattedContent = content.replaceAll(
-          "(<ListBucketResult)", XSL + "$1");
+      BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(resp.getOutputStream()));
+      String formattedContent = content.replaceAll("(<ListBucketResult)", XSL + "$1");
       writer.append(formattedContent);
       writer.flush();
       resp.setStatus(HTTP_OK);