Skip to content

Maven GAE plugin config updates #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2020
Merged

Maven GAE plugin config updates #2442

merged 5 commits into from
Mar 20, 2020

Conversation

averikitsch
Copy link
Contributor

No description provided.

@averikitsch averikitsch requested a review from a team March 19, 2020 20:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 19, 2020
lesv
lesv approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please get it to pass tests before merging.

@averikitsch averikitsch added the automerge Merge the pull request once unit tests and other checks pass. label Mar 20, 2020
@averikitsch averikitsch merged commit d18e13f into master Mar 20, 2020
@averikitsch averikitsch deleted the maven-updates4 branch March 20, 2020 15:47
@averikitsch averikitsch mentioned this pull request Mar 20, 2020
Closed
olavloite pushed a commit to olavloite/java-docs-samples that referenced this pull request Mar 22, 2020
@averikitsch @olavloite
Maven GAE plugin config updates (GoogleCloudPlatform#2442)
7464e85 
* Maven config updates

* lint

* lint

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@averikitsch @lesv @googlebot