Container Analysis Samples #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lesv
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
lesv
reviewed
Feb 12, 2018
| <name>containeranalysis</name> | ||
| <url>http://maven.apache.org</url> | ||
|
|
||
| <!-- local maven repo contains container analysis client library --> |
There was a problem hiding this comment.
How are you planning to release this?
There was a problem hiding this comment.
The library is currently publicly hosted for download on GCS, and it's on track to be added to the maven repo once it reaches beta
There was a problem hiding this comment.
Then why have you included it in the repo?
There was a problem hiding this comment.
The version currently hosted on GCS is just a .tar.gz of a gradle project, so I needed some way to integrate it into the maven project here. I'm pretty new to maven, Is there a better way to do it?
daniel-sanche
force-pushed
the
drydock
branch
from
f57be8e to
d6faa58
Compare
lesv
reviewed
Feb 12, 2018
| </parent> | ||
|
|
||
| <properties> | ||
| <maven.compiler.source>1.7</maven.compiler.source> |
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-containeranalysis</artifactId> | ||
| <version>0.1.1-0</version> |
There was a problem hiding this comment.
0 as a suffix? Why not Alpha, beta, eap??
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-tcnative-boringssl-static</artifactId> | ||
| <version>2.0.7.Final</version> |
There was a problem hiding this comment.
Not happy to see this, but I understand why it's here. Why not schedule a release w/ the Veneer team?
There was a problem hiding this comment.
As I understand it, a release is scheduled for beta, but they don't have the bandwidth to handle it in alpha
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.samples.containeranalysis; |
There was a problem hiding this comment.
com.example.containeranalysis - RFC 2606
| <name>containeranalysis</name> | ||
| <url>http://maven.apache.org</url> | ||
|
|
||
| <!-- local maven repo contains container analysis client library --> |
There was a problem hiding this comment.
Then why have you included it in the repo?
lesv
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
lesv
approved these changes
Feb 15, 2018
|
@dpebot merge when green |
|
Okay! I'll merge when all statuses are green and all reviewers approve. |
minherz
pushed a commit
that referenced
this pull request
Nov 9, 2022
…1.4 (#1024) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
…1.4 (#1024) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
…1.4 (#1024) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.4 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
…3.7.4 (#1024) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-dlp](https://github.com/googleapis/java-dlp) | `3.7.3` -> `3.7.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNy4wIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added samples and tests for drydock (container analysis). The client library currently currently isn't in the maven repo, so it's included in a jar file here.