Add DLP code samples for custom info types #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include samples of using custom dictionaries and custom regexes.
Add custom info type flags and fix existing examples so they work with the V2 API.
googlebot
added
the
cla: yes
dzlier-gcp
previously approved these changes
Jun 7, 2018
DLP now requires the client to specify info types to search for when using DeID with wildcard info types.
|
All tests are fixed. |
dzlier-gcp
approved these changes
Jun 18, 2018
|
Thanks for the approval. I don't have the ability to complete the PR by merging, so can you do that for me? Thanks. |
|
Merging current mainline into this branch - I'll merge this into master once the tests pass one more time. |
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
* Add custom info types to code samples Include samples of using custom dictionaries and custom regexes. * Add missing imports * Fix build errors * Add tests for custom info types * Fix bad regexes. * Fix bad regexes, part 2. * Update README.md Add custom info type flags and fix existing examples so they work with the V2 API. * Fix import order * Fix line length violations * Fix line length formatting violations * Fix broken character mask test DLP now requires the client to specify info types to search for when using DeID with wildcard info types. * Add SSN info type to tests * Add info types to DeID with FPE test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DLP team is in the process of expanding code samples to include features that we have launched since the initial samples were written.
In this pull request, I updated Inspect.java to include dictionary and regex based custom info types, and added some tests in InspectIT.java. Also updated the README.md file so the example commands work and are consistent with the current V2 release of the API.