Rebrand Cloud Job Discovery to Cloud Talent Solution and add the V3 code samples #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzlier-gcp
reviewed
Aug 27, 2018
|
Sorry, forgot to unify the setup steps. |
dzlier-gcp
previously approved these changes
Aug 30, 2018
| new CreateJobRequest().setJob(jobToBeCreated); | ||
|
|
||
| Job jobCreated = talentSolutionClient.projects().jobs().create(DEFAULT_PROJECT_ID, createJobRequest).execute(); | ||
| //Job jobCreated = ta.jobs().create(createJobRequest).execute(); |
| .setSessionId("HashedSessionID") | ||
| // Domain of the website where the search is conducted | ||
| .setDomain( | ||
| "www.google.com"); |
| bout.reset(); | ||
| } | ||
|
|
||
| // @Test |
|
Looks like checkstyle errors are causing Kokoro to still fail. You can run this with the maven target |
|
Done. |
dzlier-gcp
approved these changes
Sep 4, 2018
|
@dpebot Merge when green |
|
Okay! I'll merge when all statuses are green and all reviewers approve. |
|
Thank you very much! |
|
One question, why it is still "Kokoro CI Expected — Waiting for status to be reported" |
|
Ah, sorry I need to trigger a test run manually. Starting one now. |
dzlier-gcp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Thank you！
…On Wed, Sep 5, 2018 at 12:54 PM Dane Zeke Liergaard < ***@***.***> wrote:
Merged #1166
<#1166> into
master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1166 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AjXhEFLFO0E0X53ubYdPYOGx7rQ766hcks5uYCwJgaJpZM4VnTDE>
.
--
Thank you very much and have a great day!
Xinyun(Phoenix)
Mobile: 734-276-5889
Email: [email protected]
*All things come to those who wait.*
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the previous samples from cjd_sample/ to v2/ and have a new folder v3/ holding v3 samples.
Please hold the test until our V3 API is public in 8/3/2018.