storage: add list GCS objects in Java S3 SDK #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
added 2 commits
March 13, 2019 20:33
frankyn
changed the title
frankyn
added
the
do not merge
frankyn
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
frankyn
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
frankyn
removed
the
do not merge
frankyn
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
frankyn
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
kurtisvg
suggested changes
Apr 3, 2019
| // 1. Change the endpoint URL to use the Google Cloud Storage XML API endpoint. | ||
| // 2. Use Cloud Storage HMAC Credentials. | ||
| AmazonS3 interopClient = | ||
| AmazonS3ClientBuilder.standard() |
There was a problem hiding this comment.
nit: unnecessary line break
Suggested change
| AmazonS3ClientBuilder.standard() | |
| AmazonS3ClientBuilder.standard() = AmazonS3ClientBuilder.standard() |
There was a problem hiding this comment.
done also applied to list buckets sample.
| // Explicitly clean up client resources. | ||
| interopClient.shutdown(); | ||
|
|
||
| return objects; |
There was a problem hiding this comment.
New sample formats shouldn't return anything - tests should verify output via std out
There was a problem hiding this comment.
done also applied to list buckets sample.
frankyn
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
kurtisvg
suggested changes
Apr 3, 2019
| String googleAccessKeySecret) { | ||
|
|
||
| // String googleAccessKeyId = "GOOGTS7C7FUP3AIRVJTE2BCD"; |
There was a problem hiding this comment.
Are these real keys? Maybe something like this would make it more clear they need to replace with there own:
Suggested change
| // String googleAccessKeyId = "GOOGTS7C7FUP3AIRVJTE2BCD"; | |
| // String googleAccessKeyId = "your-google-access-key-id"; |
There was a problem hiding this comment.
They're close but not active/usable. I thought it made sense to show what they look like rather than their name.
I pulled these from cloud storage documentation.
…java-docs-samples into s3-sdk-list-objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Sample to list objects in GCS using S3 SDK.