Add tests to Cloud Tasks Samples #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
lesv
approved these changes
Jun 11, 2019
lesv
reviewed
Jun 11, 2019
|
|
||
| // Instantiates a client. | ||
| try (CloudTasksClient client = CloudTasksClient.create()) { | ||
| // Variables provided by the system variables. | ||
| // projectId = "my-project-id"; | ||
| // queueName = "my-queue"; | ||
| // location = "us-central1"; | ||
| // url = "https://example.com/taskhandler"; | ||
| String url = "https://example.com/taskhandler"; |
There was a problem hiding this comment.
Do you call this out in the README? (CHANGEME)
lesv
reviewed
Jun 11, 2019
| // url = "https://example.com/taskhandler"; | ||
| String payload = "hello"; | ||
| String email = args[0]; // Cloud IAM service account | ||
| String url = |
There was a problem hiding this comment.
Should we suggest changing this?
There was a problem hiding this comment.
Since this is a snippet. I have updated with the sample without a main and highlighted the parameters.
dzliergaard
approved these changes
Jun 13, 2019
|
|
||
| private ByteArrayOutputStream bout; | ||
| private PrintStream out; | ||
| // @Rule public Timeout globalTimeout = Timeout.seconds(300); // 5 minute timeout |
averikitsch
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@lesv please review changes |
lesv
approved these changes
Jun 14, 2019
averikitsch
added a commit
that referenced
this pull request
Oct 27, 2022
* Add tests * Update license * Update README * Update for testing purposes * Update queue location * Fix test styling * Library version * Update service account * Fix service account
9 tasks
averikitsch
added a commit
that referenced
this pull request
Nov 1, 2022
* Add tests * Update license * Update README * Update for testing purposes * Update queue location * Fix test styling * Library version * Update service account * Fix service account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.