Skip to content

firestore: migrate usage of getCollections to listCollections #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2019
Merged

firestore: migrate usage of getCollections to listCollections #1755

merged 2 commits into from
Dec 6, 2019

Conversation

BenWhitehead
Copy link
Contributor

No description provided.

@BenWhitehead BenWhitehead requested a review from a team November 25, 2019 19:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2019
@BenWhitehead
Copy link
Contributor Author

/cc @samtstern

@lesv
Copy link
Contributor

lesv commented Dec 6, 2019

@BenWhitehead Do you need us to merge?

@BenWhitehead
Copy link
Contributor Author

@lesv Yeah, this is currently blocked due to not having an 'Approved Review'

@lesv lesv merged commit 75caea1 into GoogleCloudPlatform:master Dec 6, 2019
@BenWhitehead BenWhitehead deleted the fs-refactor branch December 6, 2019 21:02
@BenWhitehead
Copy link
Contributor Author

Thanks for merging @lesv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@samtstern samtstern samtstern approved these changes

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenWhitehead @lesv @samtstern @googlebot