Skip to content

Add secretmanager samples #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jan 15, 2020
Merged

Add secretmanager samples #1948

merged 13 commits into from
Jan 15, 2020

Conversation

sethvargo
Copy link
Member

No description provided.

@sethvargo sethvargo requested a review from a team January 14, 2020 07:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 14, 2020
@sethvargo sethvargo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2020
@sethvargo
Copy link
Member Author

Could someone with permissions please enable the Secret Manager API on the builders:

$ gcloud services enable secretmanager.googleapis.com

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2020
@kurtisvg kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 14, 2020
@kurtisvg
Copy link
Contributor

Could someone with permissions please enable the Secret Manager API on the builders:

$ gcloud services enable secretmanager.googleapis.com

👍 Enabled

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 14, 2020
kurtisvg
kurtisvg suggested changes Jan 14, 2020
View reviewed changes
@sethvargo
Copy link
Member Author

@kurtisvg thank you for the review. I've updated the PR. Please take another look.

kurtisvg
kurtisvg suggested changes Jan 15, 2020
View reviewed changes
sethvargo
sethvargo commented Jan 15, 2020
View reviewed changes
Copy link
Member Author

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed up requested changes.

@sethvargo sethvargo merged commit 0b04cfd into GoogleCloudPlatform:master Jan 15, 2020
@sethvargo sethvargo deleted the sethvargo/secretmanager_samples branch January 15, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethvargo @kurtisvg @googlebot @kokoro-team