Skip to content

feat: add functions_firebase_auth #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 4, 2020
Merged

Conversation

grant
Copy link
Contributor

@grant grant commented Feb 3, 2020

Adds default Firebase Auth GCF handler.

@grant grant requested a review from a team February 3, 2020 07:11
@grant grant self-assigned this Feb 3, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2020
@grant grant requested a review from kurtisvg February 4, 2020 01:02

public class FirebaseAuth implements RawBackgroundFunction {

private static final Logger logger = Logger.getLogger(FirebaseAuth.class.getName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private static final Logger logger = Logger.getLogger(FirebaseAuth.class.getName());
private static final Logger LOGGER = Logger.getLogger(FirebaseAuth.class);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@grant grant merged commit 86eba3b into master Feb 4, 2020
@grant grant deleted the grant_functions_firebase_auth branch February 4, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants