Remove PowerMock from the Slack GCF sample. #2854
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using Whitebox, use package-private constructor overloads to supply the values needed by the test.
googlebot
added
the
cla: yes
|
I don't know how to test this properly, so I'm unable to validate the changes. I think the sample should probably have instructions. |
kurtisvg
approved these changes
May 7, 2020
* Clear current registry between tests. * Corrects naming on registry ID
|
@ace-n PTAL |
#2856) * healthcare API: use dataset path instead of FHIR store path when listing FHIR stores Fixes b/155924462 * Fix var
#2859) * healthcare API: fix FHIR store metadata FHIR_NAME pattern, move file from resources/ directory and rename because it applies more to FHIR stores than FHIR resources, move its test * Fix failing test
#2857) * healthcare API: fix path for FhirResourceGetHistory and make output description clearer * fix number of args, fix test for new expected output * Fix failing lint test
* Add updated quickstart and tests * Update testPermissions method to be accurate * Update flow to remove testIamPermissions * Fix removeMember ConcurrentModificationException * Lint and style fixes * Change package to iam.snippets * Update test to use UUID * Fix capitalization of UUID in variable names
#2870) * healthcare API: change how HL7v2MessageList processes results, fix error in a path name in HL7v2MessageGet * remove unused imports * remove newline * fix some paths for dataset and HL7v2 IAM methods * fix lint
Fixes b/156655272
…v1.93.6 (#3162) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-core](https://github.com/googleapis/java-core) | patch | `1.93.5` -> `1.93.6` | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v1.93.6`](https://github.com/googleapis/java-core/blob/master/CHANGELOG.md#​1936-httpswwwgithubcomgoogleapisjava-corecomparev1935v1936-2020-06-12) [Compare Source](https://github.com/googleapis/java-core/compare/v1.93.5...v1.93.6) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/java-docs-samples).
…-recommender-v1beta1 to v0.5.0 (#3164)
Fixes #issue > It's a good idea to open an issue first for discussion. - [x] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md) - [x] `pom.xml` parent set to latest `shared-configuration` - [x] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [x] **Tests** pass: `mvn clean verify` **required** - [x] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [x] Please **merge** this PR for me once it is approved.
Clean up some samples that got added with the old way of setting the parent field. See internal bug b/158100365 for context. - [X] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md) - [X] `pom.xml` parent set to latest `shared-configuration` - [X] Appropriate changes to README are included in PR - [X] API's need to be enabled to test (tell us) - [X] Environment Variables need to be set (ask us to set them) - [X] **Tests** pass: `mvn clean verify` **required** - [X] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [X] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [X] Please **merge** this PR for me once it is approved.
…er:owasp-java-html-sanitizer to v20200615 (#3171)
…cies (#3168) * Add samples for SearchAllResources and SearchAllIamPolicies * Update error handling to catch specific exceptions. * Fix static analysis issues for the newly added files; Remove arguments that are not required by tests.
Additional clarification on what to contribute. Fixes #issue > It's a good idea to open an issue first for discussion. - [x] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md) - [x] Appropriate changes to README are included in PR - [x] Please **merge** this PR for me once it is approved.
Addresses b/158467672
|
Update: I probably don't have time to work on this unless the existing tests are failing. @lesv / @saturnism - can one of you help Eamonn get the modified test passing? |
….804 (#3178) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) | patch | `1.11.803` -> `1.11.804` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/java-docs-samples).
|
@eamonnmcmanus It looks like there is some merge conflict - if you fix that, I can help figure out what's failing. |
Instead of using Whitebox, use package-private constructor overloads to supply the values needed by the test.
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
googlebot
added
cla: no
|
I may have resolved the merge conflict, or I may have borked this PR. I'm not sure whether I should really have pushed 237 commits, even if they were just from the merge. The CLA message makes me think not. |
|
This isn't important enough to spend more time on. |
9 tasks
|
@eamonnmcmanus i cherry picked the commit and created a new branch/pr based on your code, but also rebased to the latest head/trunk. ptal #3186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using Whitebox, use package-private constructor overloads
to supply the values needed by the test.