Skip to content

chore: update pubsublite/streaming-analytics #8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 8, 2023
Merged

chore: update pubsublite/streaming-analytics #8006

merged 7 commits into from
May 8, 2023

Conversation

kweinmeister
Copy link
Contributor

Updates to pubsublite/streaming-analytics:

  • Dependencies: Upgraded to latest dependencies in both Maven and Gradle build files. Removed unused dependencies. Used Libraries BOM to avoid setting a version manually for supported dependencies.

    • Note: Beam GCP dependencies were also set as a managed dependency, with precedence over Google Cloud Libraries BOM. This resolved dependency conflicts between the Libraries BOM and Beam libraries that led to missing class and method exceptions.

  • Code: resolved several warnings in the test and sample classes.

  • README: Resolved linting/formatting warnings and observed 80 character line-length.

  • Testing: Manually tested both Maven and Gradle builds.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: pubsublite Issues related to the Pub/Sub Lite API. labels May 6, 2023
@kweinmeister kweinmeister marked this pull request as ready for review May 6, 2023 20:54
@kweinmeister kweinmeister requested review from a team and yoshi-approver as code owners May 6, 2023 20:54
anguillanneuf
anguillanneuf approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your diligence @kweinmeister! 😃

@anguillanneuf anguillanneuf merged commit ab22243 into main May 8, 2023
@anguillanneuf anguillanneuf deleted the pubsublite branch May 8, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@anguillanneuf anguillanneuf

Labels
api: pubsublite Issues related to the Pub/Sub Lite API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kweinmeister @anguillanneuf