Add logging configuration to the symfony sample #556
Conversation
appengine/flexible/symfony/README.md
Outdated
| @@ -20,6 +20,13 @@ Use composer to download Symfony Standard and its dependencies | |||
| composer create-project symfony/symfony:^3.0 | |||
| ``` | |||
|
|
|||
| # Add dependency | |||
There was a problem hiding this comment.
This would be more clear as Add Composer Dependencies, but this enhancement would be better as a second section of the README, marked # Integrate Stackdriver
There was a problem hiding this comment.
Done (with the next commit)
appengine/flexible/symfony/README.md
Outdated
| @@ -31,13 +38,15 @@ git clone https://github.com/GoogleCloudPlatform/php-docs-samples /path/to/php-d | |||
|
|
|||
| # copy the two files below to the root directory of your Symfony project | |||
| cd /path/to/php-docs-samples/appengine/flexible/symfony/ | |||
| cp ./{app.yaml,nginx-app.conf} /path/to/symfony | |||
| cp app.yaml app/config/config_prod.yml \ | |||
| src/AppBundle/EventSubscriber/ExceptionSubscriber.php /path/to/symfony | |||
There was a problem hiding this comment.
This isn't going to work because it will copy these files into the root of their project, and so ExceptionSubscriber.php will not be autoloaded, and config_prod.yaml will not be in the config directory.
It would be better to add ExceptionSubscriber to our client libraries, or instead of copying it over, explain in this tutorial how to add the exception Subscriber in symfony, and link to this doc
There was a problem hiding this comment.
Fixed in the next commit
|
@bshaffer Ready for another look. The deployment test is passing locally |
appengine/flexible/symfony/README.md
Outdated
| cp app.yaml /path/to/symfony | ||
| cp app/config/config_prod.yml /path/to/symfony/app/config | ||
| cp src/AppBundle/EventSubscriber/ExceptionSubscriber.php \ | ||
| /path/to/symfony/src/AppBundle/EventSubscriber |
There was a problem hiding this comment.
By following this tutorial, the app won't have an AppBundle/EventSubscriber directory. So we'll need to add a step to create that directory. Also, I would think we'd need to add AppBundle to composer.json for autoloading, but strangely the tests do not seem to do that, so I'm not totally sure how that class is being loaded and integrated.
There was a problem hiding this comment.
there is a line for mkdir. The file is automatically loaded by symfony.
There was a problem hiding this comment.
Ahh I missed it. Let's call out "Create a directory for the Exception Subscriber" in a comment and separate it from "copy the three files"
Looking at the composer.json generated by symfony, I do not see anywhere that autoloading would occur.
There was a problem hiding this comment.
@bshaffer Done for the README.
It's automatically loaded. See:
http://symfony.com/doc/3.4/event_dispatcher.html
That's it! Your services.yml file should already be setup to load services from the EventSubscriber directory. Symfony takes care of the rest.
No description provided.