Skip to content

Changes to running the Python MQTT example #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Changes to running the Python MQTT example #1164

merged 1 commit into from
Oct 13, 2017

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Oct 12, 2017

  • Remove required flag from --message_type flag
  • Add 443 port as option for --mqtt_bridge_port flag

* Remove required flag from message_type
* Add 443 port as option for mqtt_bridge_port
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2017
@theacodes theacodes requested a review from gguuss October 12, 2017 20:56
@theacodes
Copy link
Contributor

@gguuss can you review?

@noerog
Copy link
Contributor Author

noerog commented Oct 12, 2017

I removed the requirement for --message_type because it seemed unnecessary and also wasn't specified in any of the examples. Also, in the cloud shell, I had to use port 443.

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@theacodes theacodes merged commit d45749d into GoogleCloudPlatform:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants