Created new route for results and added redirect for main. #2069
Conversation
googlebot
added
the
cla: yes
|
|
||
|
|
||
| def test_results(flask_client): | ||
| r = flask_client.get('/') |
There was a problem hiding this comment.
Does this test pass? I think by default the test client doesn't follow redirects. You'll need to pass in follow_redirects=True. See: http://flask.pocoo.org/docs/1.0/testing/#logging-in-and-out
There was a problem hiding this comment.
Also, this test is now identical to test_main. You should update test_main to check that the redirect goes where expected.
There was a problem hiding this comment.
test_main_timeout will also need follow_redirects=True. You should rename that test to test_results_timeout.
There was a problem hiding this comment.
Renamed the functions as directed and made changes to tests in order for them to pass. Thx!
| location = flask.request.args.get("location") | ||
|
|
||
| bigquery_client = bigquery.Client(project=project_id, location=location) | ||
| query_job = bigquery_client.get_job(job_id) |
There was a problem hiding this comment.
get_job takes a project and location argument. (See reference). You don't need to create a client in the line above. Instead, pass the project and location here to get_job on the existing (global) bigquery_client.
There was a problem hiding this comment.
Removed line 58 and changed to:
query_job = bigquery_client.get_job(job_id, project=project_id, location=location) as suggested!
|
@dpebot merge on green |
|
Okay! I'll merge when all statuses are green and all reviewers approve. |
dpebot
added
the
automerge
Part of the BigQuery App Engine redesign.