Skip to content

App Engine: add a setup step in README #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 30, 2019
Merged

Conversation

anguillanneuf
Copy link
Member

@anguillanneuf anguillanneuf commented Dec 13, 2019

Two service accounts are used in this tutorial. One belongs to Cloud Pub/Sub to allow it to generate auth tokens, the other belongs to push messages delivered to the push endpoint for auth and authz purposes.

This PR clarifies the differences between them.

To view the changed file: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/961d16ae98ee82f2467fc3dd228a13bbe22756eb/appengine/standard_python37/pubsub/README.md

@anguillanneuf anguillanneuf requested a review from a team as a code owner December 13, 2019 02:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 13, 2019
@anguillanneuf anguillanneuf changed the title App Engine: add a setup step in CLI App Engine: add a setup step in README Dec 13, 2019
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole leahecole merged commit 3c68ec3 into master Dec 30, 2019
@leahecole leahecole deleted the anguillanneuf-patch-3 branch December 30, 2019 17:05
crwilcox pushed a commit that referenced this pull request Dec 30, 2019
leahecole pushed a commit that referenced this pull request Jan 2, 2020
…up (#2667)

* fix: harden the wait for consistency for firestore multiple listen snippet

* fix: formatting

* add a setup step in CLI (#2611)

* fix: formatting

* fix: formatting

* fix: add setup to snippets for tests

* fix: rename sydney_query to denver_query as it refers to denver

* fix: Use stream instead of get in samples

* fix: stop deleting LA, delete DEN instead

* fix: move delete tests to end of file

* fix: move BJ to top to work with snapshot cursors

* fix: Beijing -> BJ

* during delete collection delete all collections created for these tests

* fix: add cleanup test to distributed counters

* wrap db.collections calls to use unique names

* fix: remove unused import

* fix: remove more complicated fix for time now that we have separate collections

* fix: reorder tests

* fix: move test firestore client to test file

* fix: lint

* fix: use old-style classes for Python 2.7

Co-authored-by: Tianzi Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants