Skip to content

Update CODEOWNERS #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 17, 2020
Merged

Update CODEOWNERS #2659

merged 8 commits into from
Jan 17, 2020

Conversation

busunkim96
Copy link
Contributor

@GoogleCloudPlatform/python-samples-owners Could you do a first pass through this list? After that I will open it up to individuals listed below.

This was roughly my thought process:
Inspect the recent history:

  • Is there a DPE who has made product-specific updates in the last year?
    • YES: Assign as owner.
    • NO: Is there a Tech Writer who has made product-specific sample updates in the last year?
      • YES: Assign as owner.
      • NO: Leave unassigned.

@busunkim96 busunkim96 requested a review from a team as a code owner December 24, 2019 00:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 24, 2019
gguuss
gguuss suggested changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement over what we had before. If we support multiple owners, that could also help for some of the feature areas.

.github/CODEOWNERS Outdated
/pubsub/ @anguillanneuf
/auth/ @busunkim96
/automl/ @nnegrey
/bigquery/ @tswast
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace with Seth Hollyman as Tim is moving on to another team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced mentions of tswast with shollyman

.github/CODEOWNERS Outdated
/notebooks/ @alixhami
/opencensus/
/profiler/ @jqll
/pubsub/ @anguillanneuf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we support multiple owners, maybe add hongalex here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

.github/CODEOWNERS Outdated
/memorystore/
/ml_engine/ @alecglassford
/monitoring/
/notebooks/ @alixhami
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Torry also has contributed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

kurtisvg
kurtisvg suggested changes Dec 26, 2019
View reviewed changes
.github/CODEOWNERS Outdated

# Torry Yang is the primary maintainer of the Tables samples.
/tables/ @sirtorry
* @GoogleCloudPlatform/python-samples-owners
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue we'll have to resolve at some point is how to handle reviewers from two different sets we discussed at the last meeting:

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.
*.js    @js-owner

So this means that currently any changes to just the samples won't trigger/require a review from the "python samples readability" set.

One work around to this might be to d something like this for each entry:

/cloud-sql/                     @kvg @GoogleCloudPlatform/python-samples-owners

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

.github/CODEOWNERS Outdated
/bigquery/ @tswast
/bigquery_storage/ @tswast
/bigtable/ @billyjacobson
/blog/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we comment out folders that don't have specific owners? I'm not sure if leaving it blank explicitly changes it to "no-owner"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that seems to be the case, I've added python-samples-owners as an owner for every folder, so there are no longer blank folders.

leahecole
leahecole reviewed Jan 3, 2020
View reviewed changes
gguuss
gguuss approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 merged commit 98049f4 into GoogleCloudPlatform:master Jan 17, 2020
@busunkim96 busunkim96 deleted the add-codeowners branch January 17, 2020 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@leahecole leahecole Awaiting requested review from leahecole

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@busunkim96 @gguuss @leahecole @kurtisvg @googlebot