Skip to content

fix make_iap_request #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 15, 2020
Merged

fix make_iap_request #3731

merged 4 commits into from
May 15, 2020

Conversation

3a3
Copy link
Contributor

@3a3 3a3 commented May 12, 2020 •
edited by kurtisvg
Loading

Fixes #3732

@3a3 3a3 requested review from grant and a team as code owners May 12, 2020 01:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2020
@3a3 3a3 mentioned this pull request May 12, 2020
Closed
@leahecole leahecole self-requested a review May 12, 2020 05:41
@kurtisvg kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2020
@kurtisvg
Copy link
Contributor

@leahecole - FYI

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2020
@leahecole
Copy link
Collaborator

I need to double check it in the context of the tutorial

@leahecole leahecole added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 12, 2020
arithmetic1728
arithmetic1728 suggested changes May 13, 2020
View reviewed changes
@leahecole leahecole removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 15, 2020
leahecole
leahecole approved these changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arithmetic1728 is ok with it according to the issue, and I tested the code in my Composer environment and it worked fine. Thank you for the contribution!

@leahecole leahecole added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2020
@leahecole leahecole merged commit fb25b01 into GoogleCloudPlatform:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 requested changes

@leahecole leahecole leahecole approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@grant grant Awaiting requested review from grant

Assignees

@kurtisvg kurtisvg

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[composer] Triggering Cloud Storage doesnt work
7 participants
@3a3 @kurtisvg @leahecole @arithmetic1728 @googlebot @kokoro-team @crwilcox