Skip to content

[healthcare] testing: use fixture for fhir_store #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2020
Merged

[healthcare] testing: use fixture for fhir_store #4028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e1f90
[healthcare] testing: use fixture for fhir_store
Jun 9, 2020
7de5aa2
Merge branch 'master' into fix-healthcare
Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 47 additions & 56 deletions healthcare/api-client/fhir/fhir_stores_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

dataset_id = "test_dataset_{}".format(uuid.uuid4())
fhir_store_id = "test_fhir_store-{}".format(uuid.uuid4())
test_fhir_store_id = "test_fhir_store-{}".format(uuid.uuid4())

gcs_uri = os.environ["CLOUD_STORAGE_BUCKET"]
RESOURCES = os.path.join(os.path.dirname(__file__), "resources")
Expand All @@ -53,6 +54,39 @@ def test_dataset():
datasets.delete_dataset(service_account_json, project_id, cloud_region, dataset_id)


@pytest.fixture(scope="module")
def test_fhir_store():
resp = fhir_stores.create_fhir_store(
service_account_json, project_id, cloud_region, dataset_id,
test_fhir_store_id
)

yield resp

fhir_stores.delete_fhir_store(
service_account_json, project_id, cloud_region, dataset_id,
test_fhir_store_id
)


@pytest.fixture(scope="module")
def test_blob():
storage_client = storage.Client()
bucket = storage_client.get_bucket(gcs_uri)
blob = bucket.blob(source_file_name)

blob.upload_from_filename(resource_file)

yield blob

# Clean up
try:
blob.delete()
# If blob not found, then it's already been deleted, so no need to clean up.
except exceptions.NotFound as e:
print(f'Ignoring 404: {str(e)}')


def test_CRUD_fhir_store(test_dataset, capsys):
fhir_stores.create_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
Expand All @@ -79,110 +113,67 @@ def test_CRUD_fhir_store(test_dataset, capsys):
assert "Deleted FHIR store" in out


def test_patch_fhir_store(test_dataset, capsys):
fhir_stores.create_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
)

def test_patch_fhir_store(test_dataset, test_fhir_store, capsys):
fhir_stores.patch_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
)

# Clean up
fhir_stores.delete_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
service_account_json, project_id, cloud_region, dataset_id,
test_fhir_store_id
)

out, _ = capsys.readouterr()

assert "Patched FHIR store" in out


def test_import_fhir_store_gcs(test_dataset, capsys):
fhir_stores.create_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
)

storage_client = storage.Client()
bucket = storage_client.get_bucket(gcs_uri)
blob = bucket.blob(source_file_name)

blob.upload_from_filename(resource_file)
def test_import_fhir_store_gcs(
test_dataset, test_fhir_store, test_blob, capsys):

time.sleep(10) # Give new blob time to propagate

fhir_stores.import_fhir_resources(
service_account_json,
project_id,
cloud_region,
dataset_id,
fhir_store_id,
test_fhir_store_id,
import_object,
)

# Clean up
try:
blob.delete()
# If blob not found, then it's already been deleted, so no need to clean up.
except exceptions.NotFound:
pass

fhir_stores.delete_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
)

out, _ = capsys.readouterr()

assert "Imported FHIR resources" in out


def test_export_fhir_store_gcs(test_dataset, capsys):
fhir_stores.create_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
)

def test_export_fhir_store_gcs(test_dataset, test_fhir_store, capsys):
fhir_stores.export_fhir_store_gcs(
service_account_json,
project_id,
cloud_region,
dataset_id,
fhir_store_id,
test_fhir_store_id,
gcs_uri,
)

# Clean up
fhir_stores.delete_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
)

out, _ = capsys.readouterr()

assert "Exported FHIR resources to bucket" in out


def test_get_set_fhir_store_iam_policy(test_dataset, capsys):
fhir_stores.create_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
)

def test_get_set_fhir_store_iam_policy(test_dataset, test_fhir_store, capsys):
get_response = fhir_stores.get_fhir_store_iam_policy(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
service_account_json, project_id, cloud_region, dataset_id,
test_fhir_store_id
)

set_response = fhir_stores.set_fhir_store_iam_policy(
service_account_json,
project_id,
cloud_region,
dataset_id,
fhir_store_id,
test_fhir_store_id,
"serviceAccount:[email protected]",
"roles/viewer",
)

# Clean up
fhir_stores.delete_fhir_store(
service_account_json, project_id, cloud_region, dataset_id, fhir_store_id
)

out, _ = capsys.readouterr()

assert "etag" in get_response
Expand Down