Skip to content

Typo fix on compute/oslogin/service_account_ssh.py #4420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rjmco
Copy link
Contributor

@rjmco rjmco commented Aug 1, 2020

Description

Fixes typo on compute/oslogin/service_account_ssh.py. No issue created.

Checklist

Tests were done with nox -s py-3.7 not nox -s py-3.6.

Complete nox runs:

rdcr@cloudshell:~/python-docs-samples/compute/oslogin$ /home/rdcr/.local/bin/nox -s lint
No user noxfile_config found: detail: No module named 'noxfile_config'
nox > Running session lint
nox > Creating virtual environment (virtualenv) using python3 in .nox/lint
nox > pip install flake8 flake8-import-order
nox > flake8 --show-source --builtin=gettext --max-complexity=20 --import-order-style=google --exclude=.nox,.cache,env,lib,generated_pb2,*_pb2.py,*_pb2_grpc.py --ignore=E121,E123,E126,E203,E226,E24,E266,E501,E704,
W503,W504,I202 --max-line-length=88 --application-import-names service_account_ssh_test,.nox,noxfile,service_account_ssh .
nox > Session lint was successful.
rdcr@cloudshell:~/python-docs-samples/compute/oslogin$ /home/rdcr/.local/bin/nox -s py-2.7
No user noxfile_config found: detail: No module named 'noxfile_config'
nox > Running session py-2.7
nox > Creating virtual environment (virtualenv) using python2.7 in .nox/py-2-7
nox > Session py-2.7 skipped: SKIPPED: 2.7 tests are disabled for this sample..
nox > pip install -r requirements-test.txt
nox > pytest --junitxml=sponge_log.xml
================================================================================================ test session starts ================================================================================================
platform linux -- Python 3.7.3, pytest-5.4.3, py-1.9.0, pluggy-0.13.1 -- /home/rdcr/python-docs-samples/compute/oslogin/.nox/py-3-7/bin/python
cachedir: .pytest_cache
rootdir: /home/rdcr/python-docs-samples, inifile: pytest.ini
collected 1 item                                                                                                                                                                                                    

service_account_ssh_test.py::test_main PASSED                                                                                                                                                                 [100%]

----------------------------------------------------------------- generated xml file: /home/rdcr/python-docs-samples/compute/oslogin/sponge_log.xml -----------------------------------------------------------------
=========================================================================================== 1 passed in 115.10s (0:01:55) ===========================================================================================
nox > Session py-3.7 was successful.

@rjmco rjmco requested a review from a team as a code owner August 1, 2020 21:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2020
@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed automerge Merge the pull request once unit tests and other checks pass. labels Aug 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 3, 2020
@rjmco
Copy link
Contributor Author

rjmco commented Aug 5, 2020

@tmatsuo Hi. Could you help me get this PR merged? I can't do it myself and I don't know if I am missing a step. Thank you.

@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit e2438ff into GoogleCloudPlatform:master Aug 5, 2020
@rjmco rjmco deleted the rjmco-fix-service_account_ssh-typo branch August 5, 2020 20:26
@rjmco
Copy link
Contributor Author

rjmco commented Aug 5, 2020

@busunkim96 thank you for the help! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants