Skip to content

xmpp wikibot for GCE #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2016
Merged

xmpp wikibot for GCE #618

merged 2 commits into from
Oct 26, 2016

Conversation

jerjou
Copy link
Contributor

@jerjou jerjou commented Oct 26, 2016

@mogar1980 fixed some style issues, and cleaned some stuff up. PTAL

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 26, 2016


def run_server(host='0.0.0.0'):
app.run(threaded=False, use_reloader=False, host=host)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug=False here, please. We shouldn't be using Flask's dev server to serve public traffic at all, but at least disable the debug flag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I know . The setup gets increasingly more complex if I try to do the right thing with a real web server. Jerjou and I discussed possibly removing the server component altogether as the chat interactions are more interesting anyway. Will refine tomorrow. Thanks for all the help!

Copy link
Contributor

@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for now.

@jerjou jerjou merged commit d978f5b into master Oct 26, 2016
@jerjou jerjou deleted the mogar1980 branch October 26, 2016 20:08
@jerjou
Copy link
Contributor Author

jerjou commented Oct 26, 2016

Whoops. My push errored out without my noticing, so I merged before adding debug=False. Will fix in subsequent CL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants