chore(tests): Improving the tests for OSLogin SSH sample #8486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dan Lee <[email protected]>
product-auto-label
bot
added
the
samples
Signed-off-by: Maciej Strzelczyk <[email protected]>
|
I want to change the test behavior to preserve the instances for which it fails. This way I can try to debug it better, as it happens very rarely. |
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
rsamborski
approved these changes
Jan 12, 2023
m-strzelczyk
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
dandhlee
approved these changes
Jan 18, 2023
kweinmeister
added
do not merge
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* docs(samples): New version of the OSLogin SSH script * Adding tests for the new snippet * Fixing test * Fixing lint problems * Adding region tag to new sample * Apply suggestions from code review Co-authored-by: Dan Lee <[email protected]> * Fixing some issues * Better exception handling * Fixing typing * Fixing typing * Making test more tolerant of ssh failures * Linting * Re-raising the exception if ssh fails too many times. * Improving error reporting * Making test more understanding with firewalls * Updating file name + linting. * Trying a different approach Signed-off-by: Maciej Strzelczyk <[email protected]> * Changing the behavior of test to preserve instances of failed tests. Signed-off-by: Maciej Strzelczyk <[email protected]> Co-authored-by: Dan Lee <[email protected]> Co-authored-by: Karl Weinmeister <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #8476
Issue #8429
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)