Skip to content

Update api_key_test.py for flaky test #8823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jan 24, 2023
Merged

Update api_key_test.py for flaky test #8823

merged 27 commits into from
Jan 24, 2023

Conversation

Sita04
Copy link
Collaborator

@Sita04 Sita04 commented Dec 19, 2022

Fixes #8787

@Sita04 Sita04 requested review from arithmetic1728 and a team as code owners December 19, 2022 13:56
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 19, 2022
@Sita04 Sita04 marked this pull request as draft December 19, 2022 14:08
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 19, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 19, 2022
@Sita04 Sita04 added the snippet-bot:force-run Force snippet-bot runs its logic label Dec 19, 2022
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Dec 19, 2022
@Sita04 Sita04 marked this pull request as ready for review December 19, 2022 20:11
Copy link
Contributor

@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea assigned Sita04 and unassigned kurtisvg Jan 9, 2023
@Sita04 Sita04 requested review from leahecole and removed request for leahecole January 11, 2023 04:01
@kweinmeister kweinmeister added the automerge Merge the pull request once unit tests and other checks pass. label Jan 19, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 20, 2023
@kweinmeister kweinmeister added the automerge Merge the pull request once unit tests and other checks pass. label Jan 20, 2023
@kweinmeister
Copy link
Contributor

@Sita04 it's hard to tell with all the build failures, but there is a Lint issue blocking this from getting merged:

./api_key_test.py:19:1: I100 Import statements are in the wrong order. 'from _pytest.capture import CaptureFixture' should be before 'import backoff'

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 21, 2023
@kweinmeister kweinmeister added the automerge Merge the pull request once unit tests and other checks pass. label Jan 23, 2023
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2023
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 24, 2023
@kweinmeister kweinmeister added the automerge Merge the pull request once unit tests and other checks pass. label Jan 24, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 75e9544 into main Jan 24, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the Sita04-patch-1 branch January 24, 2023 07:26
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 24, 2023
telpirion pushed a commit that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth.api-client.api_key_test: test_authenticate_with_api_key failed
8 participants