Skip to content

chore(functions/tips-gcp-apis):update sample to use functions framework declarative signature #8985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

chore(functions/tips-gcp-apis):update sample to use functions framework declarative signature #8985

merged 1 commit into from
Jan 18, 2023

Conversation

kenneth-rosario
Copy link

@kenneth-rosario kenneth-rosario commented Jan 13, 2023 •
edited
Loading

Update python sample https://cloud.google.com/functions/docs/samples/functions-tips-gcp-apis to use declarative function framework signature.

Tested by:

  1. Running local tests
  2. Deploying function and creating a pubsub topic for testing. Messages arrived as expected.

@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Jan 13, 2023
@kenneth-rosario kenneth-rosario changed the title chore(functions/tips-gcp-apis):update sample to use functions framework signature chore(functions/tips-gcp-apis):update sample to use functions framework declarative signature Jan 14, 2023
@kenneth-rosario kenneth-rosario marked this pull request as ready for review January 17, 2023 17:55
@kenneth-rosario kenneth-rosario requested review from a team as code owners January 17, 2023 17:55
@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 17, 2023
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 17, 2023
@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2023
@ace-n ace-n force-pushed the update_gcp_api_call branch from cbc3e78 to a0ad8c2 Compare January 18, 2023 20:23
@ace-n ace-n force-pushed the update_gcp_api_call branch from a0ad8c2 to ee7ae44 Compare January 18, 2023 21:30
@ace-n ace-n added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 18, 2023
@ace-n ace-n merged commit b7d0d14 into GoogleCloudPlatform:main Jan 18, 2023
@kenneth-rosario kenneth-rosario deleted the update_gcp_api_call branch January 18, 2023 22:51
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@telpirion
chore(functions/tips-gcp-apis):update sample to use functions framewo…
af5ebc5 
…rk signature (#8985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenneth-rosario @engelke @ace-n @kokoro-team