chore: migrate run/idp-sql to sqlalchemy 2 #9121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
samples
…docs-samples into idp-sql-update
snippet-bot
bot
removed
the
snippet-bot:force-run
leahecole
approved these changes
Feb 27, 2023
|
style lgtm, arbitrarily assigning @averikitsch for second review or re-triage to other teammate |
averikitsch
approved these changes
Feb 28, 2023
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* chore: migrate run/idp-sql to sqlalchemy 2 * linting * temp remove cleanup for debugging * switch to db.begin() for commits * remove cleanup for debugging * fix index parameters * add back cleanup --------- Co-authored-by: Averi Kitsch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLAlchemy 2.x PR updates are blocked on the
run/idp-sqlsample that uses 1.x syntax.The main changes were:
sqlalchemy.text()to wrap SQL statementsdb.begin()rather thandb.connect()to ensure commits were occurring as needed (2.x dropped auto-commit by default)