This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Remove docker dependency for local images #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Sep 21, 2017
cmd/analyze.go
Outdated
| @@ -51,21 +50,20 @@ var analyzeCmd = &cobra.Command{ | |||
|
|
|||
| func checkAnalyzeArgNum(args []string) error { | |||
| if len(args) != 1 { | |||
| return errors.New("'analyze' requires one image as an argument: container analyze [image]") | |||
| return fmt.Errorf("'analyze' requires one image as an argument: container-diff analyze [image]") | |||
There was a problem hiding this comment.
errors.New is fine here, it's basically the same as fmt.Errorf except fmt does formatting. You're not adding any arguments so we should stick to errors.New
dlorenc
approved these changes
Sep 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on the docker client for retrieving images from the local docker daemon in favor of using the containers/image library. The client will now only be used when examining docker history.
Also, fix the tar extension check, cleanup some error handling.
cc @dlorenc