This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Create a bazel rule for container diff #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Sep 28, 2017
docker_diff.bzl
Outdated
| image_location = ctx.executable.image.short_path | ||
| cd_binary_loction = ctx.executable._container_diff_tool.short_path | ||
|
|
||
| content = "%s diff %s %s" % (cd_binary_loction, image_location, ctx.attr.diff_base) |
There was a problem hiding this comment.
Could you make this a multi-line string, with a #!/bin/bash header and a set-e line?
docker_diff.bzl
Outdated
| allow_files = [".tar"], | ||
| single_file = True, | ||
| mandatory = True, | ||
| executable = True, |
There was a problem hiding this comment.
Do we need executable since we're requiring the .tar?
priyawadhwa
force-pushed
the
container-diff-bazel-rule
branch
from
8f5dd14 to
545765d
Compare
dlorenc
approved these changes
Oct 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a bazel rule to diff an image built by bazel (as a tar) against an image in production with container-diff.