This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Unpack layers in memory instead of extracting to disk first. #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
previously approved these changes
Oct 3, 2017
nkubala
reviewed
Oct 3, 2017
pkg/util/docker_utils.go
Outdated
| } | ||
| return imageManifest[0].Layers, nil | ||
| } | ||
|
|
||
| func unpackDockerSave(tarPath string, target string) error { | ||
| if _, ok := os.Stat(target); ok != nil { | ||
| os.MkdirAll(target, 0777) | ||
| os.MkdirAll(target, 0644) |
There was a problem hiding this comment.
Hmm, looks like you're getting permission errors on the test files now. I think you need to increase this to 666?
nkubala
approved these changes
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.