Add a cloudbuild.yaml trigger for container-diff releases. #125
Conversation
| args: ['make', 'cross'] | ||
| # Upload to GCS. | ||
| - name: 'gcr.io/cloud-builders/gsutil' | ||
| args: ['cp', '-r', 'out/*', 'gs://container-diff/builds/$COMMIT_SHA/'] |
There was a problem hiding this comment.
Might be worthwhile to have a tag-watcher cloudbuild too?
There was a problem hiding this comment.
Sorry, what's a tag-watcher?
There was a problem hiding this comment.
Lol sorry - "trigger" was the word I was looking for. Not sure where I got "tag-watcher"
There was a problem hiding this comment.
Still not following... :)
There was a problem hiding this comment.
My plan was to submit this then setup a trigger in the UI to run this for every commit to master. Is that what you're asking for?
There was a problem hiding this comment.
I was just suggesting that you add another cloudbuild.yaml using the same dockerfile, but triggered only when new tags are pushed (instead of every commit), with the step being slightly different:
args: ['cp', '-r', 'out/*', 'gs://container-diff/releases/$TAG_NAME/']
There was a problem hiding this comment.
I think thats what @nkubala was planning to do eventually?
There was a problem hiding this comment.
yeah I think we had originally talked about adding that. that way we can have the actual releases automated for us as well, as soon as the Github release gets published we get the binaries uploaded to the correct directories. we might also consider adding a
args: ['cp', '-r', 'out/*', 'gs://container-diff/releases/latest/']
to that cloudbuild (to release the newest tag as latest), though we might want to have that in a different job so we can do rollbacks easily.
There was a problem hiding this comment.
Ah, yeah. I was thinking we'd have a separate release job to tag "latest" here.
No description provided.