Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

test(GetAnalyzers): add unit tests #133

Merged
merged 1 commit into from
Nov 19, 2017
Merged

test(GetAnalyzers): add unit tests #133

merged 1 commit into from
Nov 19, 2017

Conversation

surajssd
Copy link
Contributor

No description provided.

r2d4
r2d4 reviewed Nov 18, 2017
View reviewed changes
Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to regenerate the BUILD files with
BUILD files out of date. Run 'bazel run //:gazelle' to update them.

Otherwise, LGTM, thanks!

@surajssd surajssd force-pushed the add-test-getanalyzers branch from 495f79c to 909e1ac Compare November 19, 2017 03:00
@surajssd
Copy link
Contributor Author

@r2d4 it's done! :-)

r2d4
r2d4 approved these changes Nov 19, 2017
View reviewed changes
Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@r2d4 r2d4 merged commit 6d90f74 into GoogleContainerTools:master Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@r2d4 r2d4 r2d4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surajssd @r2d4