Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Do not overwrite the loaded tarball image #240

Merged

Conversation

davidcassany
Copy link
Contributor

This commit makes sure that if the provided argument is a local
tarfile, the loaded image into the img varible does not get
overwritten by trying to fetch something from a remote registry.

From what I understand the img variable initialized in

img, err = tarball.ImageFromPath(imageName, nil)
is always ignored by assuming the given argument is a remote reference.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@davidcassany
Copy link
Contributor Author

I signed it!

@davidcassany
Copy link
Contributor Author

davidcassany commented Jun 12, 2018

I signed it!

Hopefully with correct settings this time

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

memo Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

This commit makes sure that if the provided argument is a local
tarfile, the loaded image into the `img` varible does not get
overwritten by trying to fetch something from a remote registry.
@davidcassany davidcassany force-pushed the fix_local_tarfile_loading branch from e38d6cf to 4a2db00 Compare June 13, 2018 08:46
@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@nkubala nkubala merged commit bca6c56 into GoogleContainerTools:master Jun 13, 2018
@davidcassany davidcassany deleted the fix_local_tarfile_loading branch June 14, 2018 07:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants