Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Fix local repo paths in contributor guidance. #253

Closed
wants to merge 4 commits into from
Closed

Fix local repo paths in contributor guidance. #253

wants to merge 4 commits into from

Conversation

deorbit
Copy link
Contributor

@deorbit deorbit commented Aug 4, 2018

Configuring the repository will fail with the given paths (will clone into $GOPATH/src/github.com/GoogleContainerTools, subsequent cd and git remote add will fail).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@deorbit
Copy link
Contributor Author

deorbit commented Aug 4, 2018

CLA signed and sealed.

@googlebot
Copy link

CLAs look good, thanks!

@deorbit
Copy link
Contributor Author

deorbit commented Aug 4, 2018

With my previous commit, import paths won't work, so I've changed guidance further to clone into $GOPATH/src/github.com/GoogleContainerTools and set the contributor's repo as a remote there after guidance by @campoy (http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html)

@nkubala
Copy link
Contributor

nkubala commented Aug 10, 2018

The reason this didn't work originally is because we were missing the last part of the directory path in the git clone line:

git clone [email protected]:<your_account>/container-diff.git
$GOPATH/src/github.com/GoogleContainerTools

should be

git clone [email protected]:<your_account>/container-diff.git
$GOPATH/src/github.com/GoogleContainerTools/container-diff

That should make the flow we were trying to specify work, could you just update the original clone path?

@deorbit
Copy link
Contributor Author

deorbit commented Aug 11, 2018

@nkubala Makes sense! I've cleaned up the branch this PR came from and issued PR #255 under a new branch of my fork.

@deorbit deorbit closed this Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants