Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Adding json processing example to ReadMe #26

Merged
merged 3 commits into from
Aug 18, 2017

Conversation

abbytiz
Copy link
Contributor

@abbytiz abbytiz commented Aug 17, 2017

@@ -191,8 +191,63 @@ Packages found only in gcr.io/google-appengine/python:2017-06-29-190410: None
Version differences: None

```
## Example Run with json post-processing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it may be more interesting to include the actual json (I would make a very small sample one, not necessarily based on an existing image or anything) and the results of processing that json than to include the python script itself. Then you could just say-- I had this json created by running the node, pip, and apt differ on two images, and my python script did x, y, z to produce this output, etc....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkubala @aaron-prindle any preferences on including vs not including the python script? I had gotten the vibe that an example would include the actual post-processing script as a full example...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably fine to include the python code you used to process. anything that makes this easier for people to start using is a good thing imo :) but I also agree with @cftorres, it might also be useful to show a bit of the json that the script consumes to produce that final output. don't think I'd put the whole thing though, we don't want to pollute the readme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a snippet of the json. Let me know if it's too little/too much/etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abbytiz abbytiz merged commit 19582af into GoogleContainerTools:master Aug 18, 2017
@abbytiz abbytiz deleted the jsonPostProcessExample branch August 18, 2017 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants