Adding size info to file diff/analysis #30
Conversation
| stat, err := os.Stat(path) | ||
| if err != nil { | ||
| glog.Errorf("Could not obtain size for %s: %s", path, err) | ||
| return -1 |
There was a problem hiding this comment.
seems to me that if we hit an error here, we have another problem and probably want to throw some kind of error, rather than just silently returning -1 (which will just get outputted silently). WDYT?
There was a problem hiding this comment.
The next thing I was working on was modifying the human-readable output, to check for any sizes that = -1 and outputting "unknown" or "error" or something under the size column instead of -1. The reason I didn't want to error out when the size of a particular file could not be found was to allow the rest of the analysis to be performed for the non-problematic files regardless of potential size retrieval errors.
There was a problem hiding this comment.
ok that's fine. if we start seeing errors happen there we should probably investigate the root cause, but for now this should be good.
fixes #28
@aaron-prindle @nkubala