Upgrade to go 1.14 and go.mod #329
Conversation
There was a problem hiding this comment.
@antechrestos thanks for digging into this one! it's long overdue :)
not sure I understand why we moved cmd/ to cmd/container-diff/cmd. this makes the import statements look very strange...
"github.com/GoogleContainerTools/container-diff/cmd/container-diff/cmd/util/output"
|
@antechrestos ah makes sense I see what you were doing. yeah this is more in line with what we do in https://github.com/GoogleContainerTools/skaffold - code related to the actual commands goes in I'm wondering...would you be willing to try and split some code out into either way, I'd love if you could split out any refactors into a separate PR so we can get the restructure/naming right there. then this PR will be just go 1.14 related stuff and I'm happy to merge it! thanks for giving this project a little bit of love 🙏 |
|
@nkubala would you agree doing the contrary: forget any renaming / move of this MR and just go to go 1.14 and go mod then I can clean things? It would allow us to benefit go module. Then I can start cleaning things. If you agree, this merge requests only contains changes relative to upgrading to go 1.14 |
|
@antechrestos yep that sounds good to me! |
This change was done by running the command * go mod init github.com/GoogleContainerTools/container-diff * go mod tidy * rm -rf vendor && go mod vendor See #328
|
@nkubala I've rework my branch to split the migration to golang 1.4 in one commit and the go module one to another commit. This branch does not brings any other change but these one. |
There was a problem hiding this comment.
this builds locally for me and LGTM, @antechrestos thanks so much for taking the time to do this!
Stuck at home due to covid restriction, I finally got time to wrote this contribution 😏