This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Enhances size output #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cftorres
force-pushed
the
FixSizeOutput
branch
from
8048180 to
9b3ea71
Compare
nkubala
reviewed
Aug 21, 2017
| }, | ||
| "libpython3.5-stdlib": { | ||
| "Version": "3.5.3-1", | ||
| "Size": "9896" | ||
| "Size": 10133504 |
There was a problem hiding this comment.
whoa. what changed to make these results so different?
There was a problem hiding this comment.
Previously these were in KB for the Apt differ but since the rest of the differs' sizes are in Bytes, and the new bytefmt library usage requires the input to be bytes, I converted them
There was a problem hiding this comment.
just seems like these numbers are pretty different. I trust the new method more though.
nkubala
approved these changes
Aug 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31
Previously, all the size fields were strings representing bytes, but I thought it'd be better to leave them as ints in case any numerical analysis ever needed to be performed on them... Also, now I use the bytefmt library to be able to output those ints as B, MB, KB, etc. strings for the human-readable output instead of just bytes.
@nkubala @aaron-prindle