This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Fixing default search for /etc/docker/certs.d by image library #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d4
reviewed
Aug 24, 2017
utils/image_prep_utils.go
Outdated
| img, err := ref.NewImage(nil) | ||
| cwd, _ := os.Getwd() | ||
| ctx := &types.SystemContext{ | ||
| DockerCertPath: cwd, |
There was a problem hiding this comment.
Only comment here is that it will fail if your PWD has any certs in it (which I found out the hard way.) I might change my PR to set this to the output of ioutil.TempDir() just to be safe.
nkubala
approved these changes
Aug 25, 2017
r2d4
approved these changes
Aug 25, 2017
|
Pretty sure we fixed this in containers/image latest master, could you try that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21
@nkubala @aaron-prindle