Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Add version command #44

Merged
merged 1 commit into from
Aug 30, 2017
Merged

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Aug 25, 2017

Fixes #25

Depends on #42

@r2d4 r2d4 changed the title Version Add version command Aug 25, 2017
@aaron-prindle
Copy link
Collaborator

Travis failed for last commit:

Error: unknown command "gcr.io/gcp-runtimes/diff-base" for "To"
Run 'To --help' for usage.
exit status 1

@r2d4
Copy link
Contributor Author

r2d4 commented Aug 28, 2017

Ah, basically the issue is that adding any subcommands makes the CLI ambiguous since the image names are passed in as unnamed args.

Might be best to remove root command usage and offer a

container-diff analyze ...
container-diff diff ...
container-diff version

I could also just add it as a flag to the root command, although -v is already taken by glog as verbosity.

WDYT @aaron-prindle @nkubala?

@aaron-prindle
Copy link
Collaborator

I think either is fine:
container-diff --version
Or refactoring so that all of the commands are subcommands. Going forward the subcommand method makes the most sense. Now it is going to be even more to type though lol:
container-diff diff gcr.io/test/test:v1 gcr.io/test/test:v2

@aaron-prindle aaron-prindle merged commit 70a176e into GoogleContainerTools:master Aug 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants