This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Always use docker client #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d4
force-pushed
the
dont-shell-to-docker
branch
from
ad5b128 to
b123ae9
Compare
|
fixes #51 |
To get NegotiateAPIVersion
r2d4
force-pushed
the
dont-shell-to-docker
branch
from
b123ae9 to
12917a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the --eng flag and never shells out to docker. Instead, it always uses the vendored docker client, negotiating the correct API version with the daemon. It also updates the docker/docker dependency.