This repository was archived by the owner on Mar 27, 2024. It is now read-only.
split container-diff into subcommands: analyze and diff #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2d4
reviewed
Aug 30, 2017
| Use: "analyze", | ||
| Short: "Analyzes an image: [image]", | ||
| Long: `Analyzes an image using the specifed analyzers as indicated via flags (see documentation for available ones).`, | ||
| Run: func(cmd *cobra.Command, args []string) { |
There was a problem hiding this comment.
I'm assuming this is just a copy-paste from the analyze and diff functions? So no need to do a full review of the code?
cmd/analyze.go
Outdated
|
|
||
| func init() { | ||
| RootCmd.AddCommand(analyzeCmd) | ||
| analyzeCmd.Flags().BoolVarP(&json, "json", "j", false, "JSON Output defines if the diff should be returned in a human readable format (false) or a JSON (true).") |
There was a problem hiding this comment.
Since analyze and diff share all the same flags, why not add a helper function here that takes a *cobra.Command and adds the same flag list to both of them?
aaron-prindle
force-pushed
the
add-subcommands
branch
from
6ff02b8 to
ad82215
Compare
|
added flag sharing fxn |
|
This PR is to add the subcommands and change the tests, no real logic was changed. The shared logic is in root.go currently and the diff and analyze fxns are in their respective cmd. Will move these out to a /pkg dir and should also probably refactor utils. |
r2d4
approved these changes
Aug 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #56