This repository was archived by the owner on Mar 27, 2024. It is now read-only.
updated cobra and switched some code to use Args concept #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
previously approved these changes
Sep 12, 2017
cmd/analyze.go
Outdated
| if len(args) != 1 { | ||
| errMessage = "'analyze' requires one image as an argument: container analyze [image]" | ||
| glog.Errorf(errMessage) | ||
| errMessage := "'analyze' requires one image as an argument: container analyze [image]" |
There was a problem hiding this comment.
nit: don't even need to make this var here, just instantiate the new error with the string directly
aaron-prindle
force-pushed
the
cobra-args
branch
from
8fc903e to
3af74ee
Compare
|
Incorporated feedback, this should be ready to merge |
nkubala
approved these changes
Sep 12, 2017
r2d4
reviewed
Sep 12, 2017
| @@ -27,6 +27,7 @@ var versionCmd = &cobra.Command{ | |||
| Use: "version", | |||
| Short: "Print the version of container-diff", | |||
| Long: `Print the version of container-diff.`, | |||
| Args: cobra.ExactArgs(0), | |||
There was a problem hiding this comment.
Nice, we should use this in minikube to replace some boilerplate
r2d4
reviewed
Sep 12, 2017
| @@ -32,15 +32,16 @@ var analyzeCmd = &cobra.Command{ | |||
| Use: "analyze", | |||
| Short: "Analyzes an image: [image]", | |||
| Long: `Analyzes an image using the specifed analyzers as indicated via flags (see documentation for available ones).`, | |||
| Run: func(cmd *cobra.Command, args []string) { | |||
| Args: func(cmd *cobra.Command, args []string) error { | |||
| if err := validateArgs(args, checkAnalyzeArgNum, checkArgType); err != nil { | |||
There was a problem hiding this comment.
Lets make an issue to replace the "arg count and type checking" to be their own flag types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.