This repository was archived by the owner on Mar 27, 2024. It is now read-only.
manually detect tar compression before attempting to unpack #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Sep 20, 2017
| @@ -87,13 +87,23 @@ func getFileSystemFromReference(ref types.ImageReference, imageName string) (str | |||
| for _, b := range img.LayerInfos() { | |||
| bi, _, err := imgSrc.GetBlob(b) | |||
| if err != nil { | |||
| glog.Errorf("Failed to pull image layer with error: %s", err) | |||
| glog.Errorf("Failed to pull image layer: %s", err) | |||
There was a problem hiding this comment.
We should probably return here right? This will continue. I realize it was like this before, but we should clean it up while you're changing the line.
There was a problem hiding this comment.
Ah yeah, don't think it makes sense to keep going here cause this totally screws up the image representation. Fixed
dlorenc
reviewed
Sep 20, 2017
nkubala
force-pushed
the
compression
branch
from
fc3d5d7 to
7ff5120
Compare
dlorenc
approved these changes
Sep 20, 2017
Turns out this actually wasn't broken before, because the local images were using the docker client to do a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also, fix the
remove()method, and fix the test.sh file.cc @dlorenc