This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Handle the case where files appear in the tar before their directories. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkubala
reviewed
Sep 21, 2017
| // It's possible for a file to be included before the directory it's in is created. | ||
| baseDir := filepath.Dir(target) | ||
| if _, err := os.Stat(baseDir); os.IsNotExist(err) { | ||
| if err := os.MkdirAll(baseDir, 0755); err != nil { |
There was a problem hiding this comment.
should we use the inherited mode from the header? header.FileInfo().mode() above
There was a problem hiding this comment.
Unfortunately the file mode doesn't work for the directory mode. I'm not really sure what the right thing to do here is.
There was a problem hiding this comment.
Ah yeah I see, I'm not really sure either. Maybe we create the directory with these permissions and then create the files inside of it with the header's permissions? I'm just worried that file permissions will be different than what's expected.
nkubala
approved these changes
Sep 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the errors like: