Convert only strings, let the driver fail for int values

Author: GromNaN

src/Query/Builder.php

@@ -518,17 +518,13 @@ public function distinct($column = false)
     public function orderBy($column, $direction = 'asc')
     {
         if (is_string($direction)) {
-            $direction = match (strtolower($direction)) {
-                'asc' => 1,
-                'desc' => -1,
-                default => throw new \InvalidArgumentException(sprintf('Order direction must be either "asc" or "desc", "%s" given.', $direction)),
+            $direction = match ($direction) {
+                'asc', 'ASC' => 1,
+                'desc', 'DESC' => -1,
+                default => throw new \InvalidArgumentException('Order direction must be "asc" or "desc".'),
             };
         }
 
-        if ($direction !== 1 && $direction !== -1) {
-            throw new \InvalidArgumentException(sprintf('Order direction must be either 1 or -1, "%s" given.', $direction));
-        }
-
         if ($column == 'natural') {
             $this->orders['$natural'] = $direction;
         } else {

tests/QueryBuilderTest.php

@@ -864,16 +864,10 @@ public function testCursor()
         }
     }
 
-    /**
-     * @testWith ["dasc"]
-     *           [0]
-     *           [10]
-     *           [true]
-     */
-    public function testOrderByInvalidDirection($direction)
+    public function testOrderByInvalidDirection()
     {
         $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Order direction must be either ');
-        DB::collection('items')->orderBy('_id', $direction)->get();
+        $this->expectExceptionMessage('Order direction must be "asc" or "desc"');
+        DB::collection('items')->orderBy('_id', 'dasc')->get();
     }
 }