This repository was archived by the owner on Aug 22, 2023. It is now read-only.
PHPORM-35 Add various tests on Model _id types
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Jul 27, 2023
|
|
||
| public static function provideId(): iterable | ||
| { | ||
| yield 'int' => [ |
There was a problem hiding this comment.
I think it would also make sense to check the expected value of the identifier, not only the type. This is relevant as the default behaviour for binary UUIDs is to cast it to a string, which is completely different from what the cast does.
There was a problem hiding this comment.
Updated the tests to validate the expected value. Using lose assertEquals because the ObjectId instance is recreated when the "model" is hydrated from the database.
alcaeus
approved these changes
Aug 2, 2023
GromNaN
added a commit
that referenced
this pull request
Aug 22, 2023
* PHPORM-35 Add various tests on Model _id * Add assertion on expected value * Test _id as array and object * Remove tests for arrays and objects as identifiers when keyType is string --------- Co-authored-by: Andreas Braun <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-35
Adding tests on _id with various types.
intandUTCDateTimeare not supported for query because the value is automatically converted tostringbyLaravel\Database\Eloquent\Builder.