Skip to content

Add streaming notes to update example file #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2021
Merged

Conversation

vmatyus
Copy link
Contributor

@vmatyus vmatyus commented Apr 28, 2021

PR summary

Fixes: <! -- link to issue -->

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Add stream handling examples in note comments to update document example.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #102 (a4b5e0b) into master (17d1ec9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files           8        8           
  Lines        7041     7041           
=======================================
  Hits         6495     6495           
  Misses        546      546           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17d1ec9...a4b5e0b. Read the comment docs.

Copy link
Contributor

@mojito317 mojito317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! +1

Copy link
Contributor

@emlaver emlaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@emlaver
Copy link
Contributor

emlaver commented May 12, 2021

@vmatyusGitHub can we update the byte stream comments in the other SDKs?

@vmatyus
Copy link
Contributor Author

vmatyus commented May 12, 2021

Updated also other language examples and unified the variable names to documentAsByteStream:

node:

go:

java:

@vmatyus
Copy link
Contributor Author

vmatyus commented May 12, 2021

Thank you for reviewing! 🙂

@vmatyus vmatyus merged commit 7a440c7 into master May 12, 2021
@vmatyus vmatyus deleted the 313-stream-example branch May 12, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants