Skip to content

refactor: replace ApiException 'code' with 'status_code' #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

emlaver
Copy link
Contributor

@emlaver emlaver commented Feb 7, 2024

PR summary

The code attribute of ApiException was recently deprecated in python-sdk-core.
This work replaces code with the new status_code attribute.

Python sdk core PR: IBM/python-sdk-core#185

Fixes: s889

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@emlaver emlaver self-assigned this Feb 7, 2024
@emlaver emlaver force-pushed the 889-replace-code-with-status-code branch from 139469a to bebacd3 Compare February 12, 2024 05:34
@emlaver emlaver force-pushed the 889-replace-code-with-status-code branch from bebacd3 to 1fbaaa0 Compare February 12, 2024 13:49
@emlaver emlaver merged commit 3f75a4a into main Feb 12, 2024
@emlaver emlaver deleted the 889-replace-code-with-status-code branch February 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants