Skip to content

Fixes/3 installation issue #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Fixes/3 installation issue #4

merged 3 commits into from
Sep 7, 2021

Conversation

reggeenr
Copy link
Collaborator

@reggeenr reggeenr commented Sep 7, 2021

PR summary

This PR fixes a configuration of this node module, which causes issues in using it properly.

Fixes: #3

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #4 (4f6ac45) into main (528bc80) will increase coverage by 100.00%.
The diff coverage is n/a.

❗ Current head 4f6ac45 differs from pull request most recent head 370cabb. Consider uploading reports for the commit 370cabb to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           main        #4        +/-   ##
===========================================
+ Coverage      0   100.00%   +100.00%     
===========================================
  Files         0         2         +2     
  Lines         0        64        +64     
  Branches      0        14        +14     
===========================================
+ Hits          0        64        +64     
Impacted Files Coverage Δ
ibm-cloud-code-engine/v1.ts 100.00% <0.00%> (ø)
lib/common.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528bc80...370cabb. Read the comment docs.

Copy link

@cgarrett-edwards cgarrett-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reggeenr reggeenr merged commit 42b5bb4 into main Sep 7, 2021
@reggeenr reggeenr deleted the fixes/3-installation-issue branch September 7, 2021 21:59
@reggeenr
Copy link
Collaborator Author

reggeenr commented Sep 7, 2021

🎉 This PR is included in version 0.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants