Skip to content

Va v4 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Va v4 #14

merged 2 commits into from
Jun 20, 2023

Conversation

mikeyoung3k
Copy link
Contributor

@mikeyoung3k mikeyoung3k commented Jun 15, 2023

PR summary

replaces vav3 API with vav4 API
crv1 API regenerated using automation for consistency

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

The VA v3 API is deprecated

What is the new behavior?

The VA v4 API will become default.
There are some new fields in results but is otherwise backwards compatible

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@frostmar
Copy link
Member

@mikeyoung3k GitHub check Developer Certificate of Origin isn't happy

@mikeyoung3k mikeyoung3k marked this pull request as draft June 16, 2023 08:33
@mikeyoung3k mikeyoung3k marked this pull request as ready for review June 20, 2023 15:35
Signed-off-by: Mike Young <[email protected]>

REAKING CHANGE: VA API V3 has been removed and replaced with VA V4
Copy link
Member

@sjhx sjhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeyoung3k mikeyoung3k merged commit d2b792d into main Jun 20, 2023
@mikeyoung3k mikeyoung3k deleted the va_v4 branch June 20, 2023 16:28
@ibm-reggie
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants