Skip to content

fix: allow javadoc generation for examples #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2022

Conversation

subinpc
Copy link
Member

@subinpc subinpc commented Sep 24, 2022

Don't skip javadoc generation for examples, as doing so seemingly leads to maven publish failure.

Signed-off-by: Subin Shekhar [email protected]

PR summary

Fixes: <! -- link to issue -->

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Don't skip javadoc generation for examples, as doing so seemingly leads to maven publish failure.

Signed-off-by: Subin Shekhar <[email protected]>
Copy link
Collaborator

@Surya-Penumatcha Surya-Penumatcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Surya-Penumatcha Surya-Penumatcha merged commit b7ce9c6 into master Sep 24, 2022
@Surya-Penumatcha Surya-Penumatcha deleted the fix-maven-publish branch September 24, 2022 15:46
@Surya-Penumatcha
Copy link
Collaborator

🎉 This PR is included in version 0.5.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants